chore(deps): align external dependencies with SMG - #7
Merged
Conversation
BugenZhao
marked this pull request as ready for review
July 13, 2026 10:42
4 tasks
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
BugenZhao
force-pushed
the
bz/align-smg-dependencies
branch
from
July 14, 2026 04:43
6e4715c to
e003581
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reqwestdependency with SMG at 0.13.4blake3minimum version with SMG at 1.8hf-hubrequestsWhy
MediaConnector::newaccepts areqwest::Client, so the standalone crate's reqwest 0.12 dependency was incompatible with SMG's reqwest 0.13 client. Reqwest 0.13 also renamed its Rustls feature torustls; explicitly forwarding each TLS choice tohf-hubkeeps model-config downloads functional now that hf-hub retains its own reqwest 0.12 dependency.SMG uses Rustls for outbound HTTP, so selecting
rustls-tlsby default keeps the standalone crate's default behavior aligned with its primary downstream. Consumers that require native TLS can selectnative-tlswith default features disabled.Downstream callers constructing
MediaConnectorwith a reqwest client should use reqwest 0.13 with this revision.Validation
cargo test --all-targetscargo test --all-targets --no-default-featurescargo clippy --all-targets -- --deny warningscargo clippy --all-targets --no-default-features -- --deny warningscargo check --all-targets --no-default-features --features hf-hub,rustls-tlscargo check --all-targets --no-default-features --features hf-hub,native-tlscargo fmt --all -- --checkThe all-features OpenCV combination is covered by GitHub Actions; the local machine does not have pkg-config/OpenCV installed.